Skip to content

doc: add missing pr-url - #26753

Closed
cjihrig wants to merge 1 commit into
nodejs:masterfrom
cjihrig:dep-fix
Closed

doc: add missing pr-url#26753
cjihrig wants to merge 1 commit into
nodejs:masterfrom
cjihrig:dep-fix

Conversation

@cjihrig

@cjihrig cjihrig commented Mar 18, 2019

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot nodejs-github-bot added deprecations Issues and PRs related to deprecations. doc Issues and PRs related to Node.js documentation. labels Mar 18, 2019
@targos targos added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Mar 18, 2019
@targos

targos commented Mar 18, 2019

Copy link
Copy Markdown
Member

👍 this comment if you approve fast-tracking

@vsemozhetbyt vsemozhetbyt added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 18, 2019
@danbev

danbev commented Mar 19, 2019

Copy link
Copy Markdown
Contributor

@danbev

danbev commented Mar 19, 2019

Copy link
Copy Markdown
Contributor

Landed in cd9898a.

@danbev danbev closed this Mar 19, 2019
danbev pushed a commit that referenced this pull request Mar 19, 2019
PR-URL: #26753
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@cjihrig
cjihrig deleted the dep-fix branch March 19, 2019 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. deprecations Issues and PRs related to deprecations. doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants