Skip to content

test: add mustCall for test-net-buffersize - #27451

Closed
iplaces wants to merge 1 commit into
nodejs:masterfrom
iplaces:master
Closed

test: add mustCall for test-net-buffersize#27451
iplaces wants to merge 1 commit into
nodejs:masterfrom
iplaces:master

Conversation

@iplaces

@iplaces iplaces commented Apr 28, 2019

Copy link
Copy Markdown
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Apr 28, 2019
@ZYSzys ZYSzys added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Apr 28, 2019
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@gireeshpunathil

Copy link
Copy Markdown
Member

please leave 👍 to fast track

@oyyd oyyd added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Apr 28, 2019
oyyd pushed a commit that referenced this pull request Apr 28, 2019
PR-URL: #27451
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
@oyyd

oyyd commented Apr 28, 2019

Copy link
Copy Markdown
Contributor

Landed in 7cbbd51, thanks!

You can visit https://www.nodetodo.org/next-steps/ for more ideas to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fast-track PRs proposed for a shorter-than-standard waiting period before landing. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants