test: add a test case for the path.posix.resolve - #27905
Merged
Merged
Conversation
addaleax
approved these changes
May 26, 2019
ryzokuken
approved these changes
May 26, 2019
ryzokuken
left a comment
Contributor
There was a problem hiding this comment.
LGTM with Anna's comments addressed, thanks!
Collaborator
Trott
approved these changes
May 27, 2019
Collaborator
gireeshpunathil
approved these changes
May 27, 2019
ChALkeR
approved these changes
May 27, 2019
Member
|
Please react with 👍for fast-tracking. |
In posix path.resolve should handle relative paths to be safe
even if process.cwd fails.
At lib/path.js#999:
return resolvedPath.length > 0 ? resolvedPath : '.';
Else branch wasn't covered.
Add a test case to cover this.
PR-URL: #27905
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Member
|
Landed in e3555e9. Thanks for the contribution! 🎉 https://www.nodetodo.org/next-steps/ is a good list of ideas on possible next steps. (But the next steps are not limited to just that list -- you can always come up with your own)! |
targos
pushed a commit
that referenced
this pull request
May 28, 2019
In posix path.resolve should handle relative paths to be safe
even if process.cwd fails.
At lib/path.js#999:
return resolvedPath.length > 0 ? resolvedPath : '.';
Else branch wasn't covered.
Add a test case to cover this.
PR-URL: #27905
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In posix path.resolve should handle relative paths to be safe even if process.cwd fails.
At
lib/path.js#999:Else branch wasn't covered.
Add a test case to cover this.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes