test: remove test-ttywrap.writestream - #28316
Merged
Merged
Conversation
gireeshpunathil
approved these changes
Jun 20, 2019
Collaborator
trivikr
approved these changes
Jun 20, 2019
Member
|
This is removing a different test than the one that is referenced in the issue … is that intentional? |
Member
Author
Argh! No, that was an error. Fixing.... |
Trott
force-pushed
the
rm-test-that-never-runs
branch
from
June 20, 2019 21:02
113bb30 to
3b97f5d
Compare
Member
Author
|
Fixed. Re-running CI.... |
Collaborator
addaleax
approved these changes
Jun 20, 2019
aks-
approved these changes
Jun 21, 2019
jasnell
approved these changes
Jun 21, 2019
Collaborator
Collaborator
Collaborator
The test is never run in CI and may have never worked. Refs: nodejs#28304 PR-URL: nodejs#28316 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Trott
force-pushed
the
rm-test-that-never-runs
branch
from
June 22, 2019 13:02
3b97f5d to
6e66313
Compare
Member
Author
|
Landed in 6e66313 |
This was referenced Jul 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test is never run in CI and may have never worked.
Refs: #28304
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes