Skip to content

test: mark test-worker-prof flaky on arm - #32826

Closed
sam-github wants to merge 1 commit into
nodejs:masterfrom
sam-github:flaky-worker-prof
Closed

test: mark test-worker-prof flaky on arm#32826
sam-github wants to merge 1 commit into
nodejs:masterfrom
sam-github:flaky-worker-prof

Conversation

@sam-github

Copy link
Copy Markdown
Contributor

Refs: #26401 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Apr 13, 2020
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@MylesBorins MylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins

Copy link
Copy Markdown
Contributor

fast-track?

@MylesBorins MylesBorins added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Apr 14, 2020
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@sam-github

Copy link
Copy Markdown
Contributor Author

I'm OK with fast-tracking, but the CI failed on unrelated tests :-(. Resumed it.

@sam-github

Copy link
Copy Markdown
Contributor Author

Landed in afae925

@sam-github sam-github closed this Apr 14, 2020
sam-github added a commit that referenced this pull request Apr 14, 2020
Refs: #26401 (comment)

PR-URL: #32826
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@sam-github
sam-github deleted the flaky-worker-prof branch April 14, 2020 17:59
MylesBorins pushed a commit that referenced this pull request Apr 17, 2020
Refs: #26401 (comment)

PR-URL: #32826
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
Refs: nodejs#26401 (comment)

PR-URL: nodejs#32826
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
Refs: #26401 (comment)

PR-URL: #32826
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Apr 28, 2020
targos pushed a commit that referenced this pull request Apr 28, 2020
Refs: #26401 (comment)

PR-URL: #32826
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track PRs proposed for a shorter-than-standard waiting period before landing. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants