Skip to content

use case-sensitive in the example - #35624

Closed
PoojaDurgad wants to merge 1 commit into
nodejs:masterfrom
PoojaDurgad:process-getreport
Closed

use case-sensitive in the example#35624
PoojaDurgad wants to merge 1 commit into
nodejs:masterfrom
PoojaDurgad:process-getreport

Conversation

@PoojaDurgad

@PoojaDurgad PoojaDurgad commented Oct 13, 2020

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. process Issues and PRs related to the process subsystem. labels Oct 13, 2020
@gireeshpunathil gireeshpunathil added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 27, 2020
@github-actions github-actions Bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 27, 2020
@github-actions

github-actions Bot commented Oct 27, 2020

Copy link
Copy Markdown
Contributor
Commit Queue failed
- Loading data for nodejs/node/pull/35624
✔  Done loading data for nodejs/node/pull/35624
----------------------------------- PR info ------------------------------------
Title      use case-sensitive in the example (#35624)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     PoojaDurgad:process-getreport -> nodejs:master
Labels     author ready, doc, process
Commits    1
 - doc: use case-sensitive in the example
Committers 1
 - Pooja D.P 
PR-URL: https://github.com/nodejs/node/pull/35624
Reviewed-By: Richard Lau 
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
Reviewed-By: Gireesh Punathil 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/35624
Reviewed-By: Richard Lau 
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
Reviewed-By: Gireesh Punathil 
--------------------------------------------------------------------------------
   ✖  GitHub CI is still running
   ℹ  Doc-only changes
   ℹ  This PR was created on Tue, 13 Oct 2020 04:48:34 GMT
   ✔  Approvals: 4
   ✔  - Richard Lau (@richardlau): https://github.com/nodejs/node/pull/35624#pullrequestreview-507076375
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/35624#pullrequestreview-507320736
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/35624#pullrequestreview-507750801
   ✔  - Gireesh Punathil (@gireeshpunathil) (TSC): https://github.com/nodejs/node/pull/35624#pullrequestreview-517357421
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

Commit Queue action: https://github.com/nodejs/node/actions/runs/330626537

@aduh95 aduh95 added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Oct 27, 2020
@github-actions github-actions Bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 27, 2020
@github-actions

github-actions Bot commented Oct 27, 2020

Copy link
Copy Markdown
Contributor

Landed in 0ca8617...cb62f16

@github-actions github-actions Bot closed this Oct 27, 2020
nodejs-github-bot pushed a commit that referenced this pull request Oct 27, 2020
@PoojaDurgad @nodejs-github-bot
doc: use case-sensitive in the example
cb62f16 
PR-URL: #35624
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Nov 3, 2020
@PoojaDurgad @targos
doc: use case-sensitive in the example
3db4354 
PR-URL: #35624
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Nov 3, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
@PoojaDurgad @BethGriggs
doc: use case-sensitive in the example
6aa1df9 
PR-URL: #35624
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@PoojaDurgad @BethGriggs
doc: use case-sensitive in the example
b72f1dd 
PR-URL: #35624
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@PoojaDurgad @BethGriggs
doc: use case-sensitive in the example
9c7d4bd 
PR-URL: #35624
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@lpinca lpinca lpinca approved these changes
@richardlau richardlau richardlau approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
@trivikr trivikr trivikr approved these changes

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. process Issues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@PoojaDurgad @Trott @lpinca @richardlau @gireeshpunathil @trivikr @aduh95 @nodejs-github-bot