Skip to content

doc: fix typo in globals.md - #37228

Closed
RaisinTen wants to merge 1 commit into
nodejs:masterfrom
RaisinTen:doc/fix-typo-in-globals
Closed

doc: fix typo in globals.md#37228
RaisinTen wants to merge 1 commit into
nodejs:masterfrom
RaisinTen:doc/fix-typo-in-globals

Conversation

@RaisinTen

Copy link
Copy Markdown
Member

No description provided.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Feb 4, 2021
@RaisinTen RaisinTen added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Feb 4, 2021
@aduh95 aduh95 added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Feb 4, 2021
@aduh95

aduh95 commented Feb 4, 2021

Copy link
Copy Markdown
Contributor

fast-track?

@ItzLevvie ItzLevvie left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jasnell

jasnell commented Feb 4, 2021

Copy link
Copy Markdown
Member

Landed in 3b36320

@jasnell jasnell closed this Feb 4, 2021
jasnell pushed a commit that referenced this pull request Feb 4, 2021
PR-URL: #37228
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RaisinTen
RaisinTen deleted the doc/fix-typo-in-globals branch February 5, 2021 13:31
danielleadams pushed a commit that referenced this pull request Feb 16, 2021
PR-URL: #37228
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Feb 16, 2021
targos pushed a commit that referenced this pull request May 1, 2021
PR-URL: #37228
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants