Skip to content

contextify: cache some context in locals - #37473

Closed
XadillaX wants to merge 2 commits into
nodejs:masterfrom
XadillaX:ctx
Closed

contextify: cache some context in locals#37473
XadillaX wants to merge 2 commits into
nodejs:masterfrom
XadillaX:ctx

Conversation

@XadillaX

@XadillaX XadillaX commented Feb 22, 2021

Copy link
Copy Markdown
Contributor

Refs: 66566df

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. vm Issues and PRs related to the vm subsystem. labels Feb 22, 2021
@XadillaX
XadillaX requested a review from devsnek February 23, 2021 02:49
@XadillaX

XadillaX commented Feb 24, 2021

Copy link
Copy Markdown
Contributor Author

/ping @nodejs/vm

targos
targos reviewed Feb 24, 2021
View reviewed changes
Comment thread src/node_contextify.cc Outdated
@XadillaX

XadillaX commented Mar 1, 2021

Copy link
Copy Markdown
Contributor Author

/ping @targos

@XadillaX XadillaX added author ready PRs with CI started, the required approvals, and no outstanding review comments. and removed author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Mar 15, 2021
@nodejs-github-bot

nodejs-github-bot commented Apr 9, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37314/

@nodejs-github-bot

nodejs-github-bot commented Apr 9, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37316/

@nodejs-github-bot

nodejs-github-bot commented Apr 9, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37318/

@nodejs-github-bot

nodejs-github-bot commented Apr 9, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37319/

@nodejs-github-bot

nodejs-github-bot commented Apr 9, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37325/

@nodejs-github-bot

nodejs-github-bot commented Apr 19, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37561/

XadillaX added a commit that referenced this pull request Apr 19, 2021
@XadillaX
src: cache some context in locals
4e9212b 
Refs: 66566df

PR-URL: #37473
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@XadillaX

XadillaX commented Apr 19, 2021

Copy link
Copy Markdown
Contributor Author

Landed in 4e9212b

@XadillaX XadillaX closed this Apr 19, 2021
@BethGriggs BethGriggs mentioned this pull request Apr 20, 2021
Merged
XadillaX added a commit to XadillaX/node that referenced this pull request Apr 23, 2021
@XadillaX
src: cache necessary isolate & context in api/*
d1f30a6 
Refs: nodejs#37473
@XadillaX XadillaX mentioned this pull request Apr 23, 2021
Closed
targos pushed a commit that referenced this pull request May 1, 2021
@XadillaX @targos
src: cache some context in locals
5ed770e 
Refs: 66566df

PR-URL: #37473
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
danielleadams pushed a commit that referenced this pull request May 8, 2021
@XadillaX @danielleadams
src: cache some context in locals
6067f95 
Refs: 66566df

PR-URL: #37473
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
XadillaX added a commit that referenced this pull request Jun 1, 2021
@XadillaX
src: cache necessary isolate & context in api/*
f52dc17 
Refs: #37473

PR-URL: #38366
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
danielleadams pushed a commit that referenced this pull request Jun 2, 2021
@XadillaX @danielleadams
src: cache necessary isolate & context in api/*
120849f 
Refs: #37473

PR-URL: #38366
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@RaisinTen RaisinTen mentioned this pull request Oct 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes
@devsnek devsnek Awaiting requested review from devsnek
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@XadillaX @nodejs-github-bot @jasnell @targos @RaisinTen