lib: properly processing JavaScript exceptions on async_hooks fatal error - #38106
Closed
legendecas wants to merge 3 commits into
Closed
lib: properly processing JavaScript exceptions on async_hooks fatal error#38106legendecas wants to merge 3 commits into
legendecas wants to merge 3 commits into
Conversation
legendecas
force-pushed
the
async_hooks/fatal_error
branch
2 times, most recently
from
April 6, 2021 04:09
bdc1aa2 to
4f5bead
Compare
aduh95
reviewed
Apr 6, 2021
aduh95
reviewed
Apr 6, 2021
…rror JavaScript exceptions could be arbitrary values.
legendecas
force-pushed
the
async_hooks/fatal_error
branch
from
April 6, 2021 11:21
4f5bead to
56f756a
Compare
aduh95
approved these changes
Apr 6, 2021
Flarna
approved these changes
Apr 7, 2021
This comment has been minimized.
This comment has been minimized.
Member
|
@legendecas Unfortunately it seems your test fails on windows (see https://ci.nodejs.org/job/node-test-binary-windows-js-suites/9219/) |
Member
Author
|
@Flarna thanks, fixed. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Flarna
approved these changes
Apr 7, 2021
jasnell
approved these changes
Apr 7, 2021
addaleax
reviewed
Apr 7, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
Flarna
approved these changes
Apr 8, 2021
Flarna
pushed a commit
that referenced
this pull request
Apr 8, 2021
JavaScript exceptions could be arbitrary values. PR-URL: #38106 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in d861324 |
targos
pushed a commit
that referenced
this pull request
May 1, 2021
JavaScript exceptions could be arbitrary values. PR-URL: #38106 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JavaScript exceptions could be arbitrary values.
Status-quo of the behavior would result in TypeError in node internals