Skip to content

lib,zlib: fix brotli flush range - #38408

Merged
Trott merged 1 commit into
nodejs:masterfrom
XadillaX:fix-brotli
May 1, 2021
Merged

lib,zlib: fix brotli flush range#38408
Trott merged 1 commit into
nodejs:masterfrom
XadillaX:fix-brotli

Conversation

@XadillaX

@XadillaX XadillaX commented Apr 26, 2021

Copy link
Copy Markdown
Contributor

Fixes: #38407

@github-actions github-actions Bot added needs-ci PRs that need a full CI run. zlib Issues and PRs related to the zlib module and its compression dependencies. labels Apr 26, 2021
@XadillaX XadillaX linked an issue Apr 26, 2021 that may be closed by this pull request
@XadillaX
XadillaX requested a review from joyeecheung April 26, 2021 11:54
Comment thread lib/zlib.js Outdated
@addaleax addaleax added the brotli Issues and PRs related to the Brotli dependency. label Apr 26, 2021
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@joyeecheung
joyeecheung removed their request for review April 28, 2021 17:34
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Fixes: nodejs#38407

PR-URL: nodejs#38408
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott

Trott commented May 1, 2021

Copy link
Copy Markdown
Member

Landed in 9c7aa96

@Trott
Trott merged commit 9c7aa96 into nodejs:master May 1, 2021
targos pushed a commit that referenced this pull request May 3, 2021
Fixes: #38407

PR-URL: #38408
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request May 3, 2021
targos pushed a commit that referenced this pull request May 30, 2021
Fixes: #38407

PR-URL: #38408
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
Fixes: #38407

PR-URL: #38408
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
Fixes: #38407

PR-URL: #38408
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jun 11, 2021
Fixes: #38407

PR-URL: #38408
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

brotli Issues and PRs related to the Brotli dependency. needs-ci PRs that need a full CI run. zlib Issues and PRs related to the zlib module and its compression dependencies.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

zlib.brotliCompressSync results in no response

6 participants