test: mark test-fs-watch-non-recursive flaky on Windows - #40916
Merged
nodejs-github-bot merged 1 commit intoNov 23, 2021
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
40 tasks
Flarna
approved these changes
Nov 22, 2021
targos
approved these changes
Nov 22, 2021
This comment has been minimized.
This comment has been minimized.
Collaborator
45 tasks
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/40916 ✔ Done loading data for nodejs/node/pull/40916 ----------------------------------- PR info ------------------------------------ Title test: mark test-fs-watch-non-recursive flaky on Windows (#40916) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch lpinca:mark/test-fs-watch-non-recursive-flaky -> nodejs:master Labels test, author ready Commits 1 - test: mark test-fs-watch-non-recursive flaky on Windows Committers 1 - Luigi Pinca PR-URL: https://github.com/nodejs/node/pull/40916 Refs: https://github.com/nodejs/node/issues/40728 Reviewed-By: Gerhard Stöbich Reviewed-By: Michaël Zasso ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40916 Refs: https://github.com/nodejs/node/issues/40728 Reviewed-By: Gerhard Stöbich Reviewed-By: Michaël Zasso -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 21 Nov 2021 20:04:09 GMT ✔ Approvals: 2 ✔ - Gerhard Stöbich (@Flarna): https://github.com/nodejs/node/pull/40916#pullrequestreview-812234955 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/40916#pullrequestreview-812236618 ✖ This PR needs to wait 5 more hours to land ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2021-11-22T13:55:43Z: https://ci.nodejs.org/job/node-test-pull-request/41044/ - Querying data for job/node-test-pull-request/41044/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1495305752 |
Collaborator
|
Landed in 2a871df |
This was referenced Nov 24, 2021
33 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #40728