Skip to content

doc: fix 404 link of BUILDING.md - #43234

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
F3n67u:fix/doc
Jun 2, 2022
Merged

doc: fix 404 link of BUILDING.md#43234
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
F3n67u:fix/doc

Conversation

@F3n67u

@F3n67u F3n67u commented May 29, 2022

Copy link
Copy Markdown
Contributor

https://boxstarter.org/WebLauncher is 404, change to https://boxstarter.org/weblauncher which is accessible now.

image

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. doc Issues and PRs related to Node.js documentation. labels May 29, 2022
@F3n67u
F3n67u marked this pull request as ready for review May 29, 2022 07:59
@RaisinTen RaisinTen added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label May 29, 2022
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 2, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 2, 2022
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/43234
FetchError: Invalid response body while trying to fetch https://github.com/@api/graphql: Premature close
    at consumeBody (file:///opt/hostedtoolcache/node/16.15.0/x64/lib/node_modules/node-core-utils/node_modules/node-fetch/src/body.js:234:60)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async Response.text (file:///opt/hostedtoolcache/node/16.15.0/x64/lib/node_modules/node-core-utils/node_modules/node-fetch/src/body.js:158:18)
    at async Request.json (file:///opt/hostedtoolcache/node/16.15.0/x64/lib/node_modules/node-core-utils/lib/request.js:51:18)
    at async Request.query (file:///opt/hostedtoolcache/node/16.15.0/x64/lib/node_modules/node-core-utils/lib/request.js:109:20)
    at async Request.queryAll (file:///opt/hostedtoolcache/node/16.15.0/x64/lib/node_modules/node-core-utils/lib/request.js:136:20)
    at async Request.gql (file:///opt/hostedtoolcache/node/16.15.0/x64/lib/node_modules/node-core-utils/lib/request.js:66:22)
    at async PRData.getComments (file:///opt/hostedtoolcache/node/16.15.0/x64/lib/node_modules/node-core-utils/lib/pr_data.js:97:21)
    at async Promise.all (index 2)
    at async Promise.all (index 1) {
  type: 'system',
  errno: 'ERR_STREAM_PREMATURE_CLOSE',
  code: 'ERR_STREAM_PREMATURE_CLOSE',
  erroredSysCall: undefined
}
https://github.com/nodejs/node/actions/runs/2429282559

@nodejs-github-bot nodejs-github-bot added the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Jun 2, 2022
@tniessen tniessen added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Jun 2, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 2, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 8f39f51 into nodejs:master Jun 2, 2022
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 8f39f51

@F3n67u
F3n67u deleted the fix/doc branch June 2, 2022 21:59
danielleadams pushed a commit that referenced this pull request Jun 11, 2022
PR-URL: #43234
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@danielleadams danielleadams mentioned this pull request Jun 11, 2022
danielleadams pushed a commit that referenced this pull request Jun 13, 2022
PR-URL: #43234
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit that referenced this pull request Jul 12, 2022
PR-URL: #43234
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #43234
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#43234
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants