trace_events: add example for docs - #43253
Merged
Merged
Conversation
ErickWendel
approved these changes
Aug 16, 2022
Collaborator
Member
|
@theanarkh btw, we don't do Jenkins CI runs on doc-only PRs :) |
Contributor
Author
|
Oh, thanks. Can it be merged directly? |
Member
|
yes! |
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/43253 ✔ Done loading data for nodejs/node/pull/43253 ----------------------------------- PR info ------------------------------------ Title trace_events: add example for docs (#43253) Author theanarkh (@theanarkh) Branch theanarkh:update_trace_events_doc -> nodejs:main Labels doc, author ready, review wanted Commits 1 - trace_events: add example Committers 1 - theanarkh <2923878201@qq.com> PR-URL: https://github.com/nodejs/node/pull/43253 Reviewed-By: Erick Wendel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43253 Reviewed-By: Erick Wendel -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 30 May 2022 18:28:01 GMT ✔ Approvals: 1 ✔ - Erick Wendel (@erickwendel): https://github.com/nodejs/node/pull/43253#pullrequestreview-1074032223 ✖ Last GitHub CI failed ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2869381073 |
Contributor
Author
|
@RaisinTen Hi, it fails because of the CI, do i need to make it green or add some labels to skip the failure ? |
Collaborator
Collaborator
|
Landed in b04f81c |
This was referenced Aug 20, 2022
ruyadorno
pushed a commit
that referenced
this pull request
Aug 23, 2022
PR-URL: #43253 Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 5, 2022
PR-URL: #43253 Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Oct 11, 2022
PR-URL: #43253 Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Jan 3, 2023
PR-URL: nodejs/node#43253 Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Jan 3, 2023
PR-URL: nodejs/node#43253 Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add example for docs.
make -j4 test(UNIX), orvcbuild test(Windows) passes