Skip to content

tools: use the v1 branch instead of a commit hash - #45164

Closed
lpinca wants to merge 1 commit into
nodejs:mainfrom
lpinca:use/v1-branch
Closed

tools: use the v1 branch instead of a commit hash#45164
lpinca wants to merge 1 commit into
nodejs:mainfrom
lpinca:use/v1-branch

Conversation

@lpinca

@lpinca lpinca commented Oct 25, 2022

Copy link
Copy Markdown
Member

Use the v1 branch for the gr2m/create-or-update-pull-request-action. Explicit tags and commit hashes do not include the dist folder.

Refs: #45022 (comment)

Use the v1 branch for the gr2m/create-or-update-pull-request-action.
Explicit tags and commit hashes do not include the `dist` folder.

Refs: nodejs#45022 (comment)
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 25, 2022
@targos targos added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Oct 25, 2022
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @targos. Please 👍 to approve.

@aduh95 aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The security concerns are still there, I don't think reverting to tags is the right move here. IMO reverting ef17711 would be a better quick fix, or finding the right hash to use would be even better.

@lpinca lpinca closed this Oct 25, 2022
@lpinca
lpinca deleted the use/v1-branch branch October 25, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track PRs proposed for a shorter-than-standard waiting period before landing. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants