Skip to content

doc: add missing documentation for paramEncoding - #45523

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
tniessen:doc-keypair-paramencoding
Nov 21, 2022
Merged

doc: add missing documentation for paramEncoding#45523
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
tniessen:doc-keypair-paramencoding

Conversation

@tniessen

Copy link
Copy Markdown
Member

This option has existed ever since generateKeyPair was added in 2019 or so, but I apparently forgot to document it.

Thanks to @panva for noticing this :)

This option has existed ever since generateKeyPair was added in 2019 or
so, but I apparently forgot to document it.
@tniessen
tniessen requested a review from panva November 19, 2022 19:49
@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to Node.js documentation. labels Nov 19, 2022
@anonrig anonrig added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 19, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 19, 2022
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@panva panva added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 19, 2022
Comment thread doc/api/crypto.md Outdated
Comment thread doc/api/crypto.md Outdated
Co-authored-by: Filip Skokan <panva.ip@gmail.com>
@panva panva added commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. commit-queue-squash PRs the Commit Queue should land as one squashed commit. and removed commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. labels Nov 20, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 21, 2022
@nodejs-github-bot
nodejs-github-bot merged commit b4666c3 into nodejs:main Nov 21, 2022
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in b4666c3

ruyadorno pushed a commit that referenced this pull request Nov 24, 2022
This option has existed ever since generateKeyPair was added in 2019 or
so, but I apparently forgot to document it.

PR-URL: #45523
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Nov 24, 2022
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
This option has existed ever since generateKeyPair was added in 2019 or
so, but I apparently forgot to document it.

PR-URL: #45523
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
This option has existed ever since generateKeyPair was added in 2019 or
so, but I apparently forgot to document it.

PR-URL: #45523
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
This option has existed ever since generateKeyPair was added in 2019 or
so, but I apparently forgot to document it.

PR-URL: #45523
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants