test_runner: don't parse TAP from stderr - #45618
Merged
Merged
Conversation
This commit stops the test runner CLI from parsing child process stderr as TAP. Per the TAP spec, TAP can only come from stdout. To avoid losing stderr data, those logs are injected into the parser as unknown tokens so that they are output as comments.
MoLow
reviewed
Nov 25, 2022
MoLow
approved these changes
Nov 26, 2022
Collaborator
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/45618 ✔ Done loading data for nodejs/node/pull/45618 ----------------------------------- PR info ------------------------------------ Title test_runner: don't parse TAP from stderr (#45618) Author Colin Ihrig (@cjihrig) Branch cjihrig:runner-2 -> nodejs:main Labels util, author ready, dont-land-on-v14.x, commit-queue-rebase, test_runner Commits 1 - test_runner: don't parse TAP from stderr Committers 1 - cjihrig PR-URL: https://github.com/nodejs/node/pull/45618 Reviewed-By: Moshe Atlow ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45618 Reviewed-By: Moshe Atlow -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 25 Nov 2022 03:02:08 GMT ✔ Approvals: 1 ✔ - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/45618#pullrequestreview-1194906306 ✖ This PR needs to wait 96 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-11-27T18:46:00Z: https://ci.nodejs.org/job/node-test-pull-request/48209/ - Querying data for job/node-test-pull-request/48209/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3561196202 |
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/45618 ✔ Done loading data for nodejs/node/pull/45618 ----------------------------------- PR info ------------------------------------ Title test_runner: don't parse TAP from stderr (#45618) Author Colin Ihrig (@cjihrig) Branch cjihrig:runner-2 -> nodejs:main Labels util, author ready, dont-land-on-v14.x, test_runner Commits 1 - test_runner: don't parse TAP from stderr Committers 1 - cjihrig PR-URL: https://github.com/nodejs/node/pull/45618 Reviewed-By: Moshe Atlow ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45618 Reviewed-By: Moshe Atlow -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 25 Nov 2022 03:02:08 GMT ✔ Approvals: 1 ✔ - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/45618#pullrequestreview-1194906306 ✖ This PR needs to wait 0 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-11-28T02:37:28Z: https://ci.nodejs.org/job/node-test-pull-request/48209/ - Querying data for job/node-test-pull-request/48209/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3598466504 |
Collaborator
|
Landed in cc2732d |
targos
pushed a commit
that referenced
this pull request
Dec 12, 2022
This commit stops the test runner CLI from parsing child process stderr as TAP. Per the TAP spec, TAP can only come from stdout. To avoid losing stderr data, those logs are injected into the parser as unknown tokens so that they are output as comments. PR-URL: #45618 Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
This commit stops the test runner CLI from parsing child process stderr as TAP. Per the TAP spec, TAP can only come from stdout. To avoid losing stderr data, those logs are injected into the parser as unknown tokens so that they are output as comments. PR-URL: #45618 Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
This commit stops the test runner CLI from parsing child process stderr as TAP. Per the TAP spec, TAP can only come from stdout. To avoid losing stderr data, those logs are injected into the parser as unknown tokens so that they are output as comments. PR-URL: #45618 Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
danielleadams
pushed a commit
that referenced
this pull request
Jan 5, 2023
This commit stops the test runner CLI from parsing child process stderr as TAP. Per the TAP spec, TAP can only come from stdout. To avoid losing stderr data, those logs are injected into the parser as unknown tokens so that they are output as comments. PR-URL: #45618 Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit stops the test runner CLI from parsing child process stderr as TAP. Per the TAP spec, TAP can only come from stdout. To avoid losing stderr data, those logs are injected into the parser as unknown tokens so that they are output as TAP comments.