lib: refactor to use validateBuffer - #46489
Merged
nodejs-github-bot merged 1 commit intoFeb 6, 2023
Merged
Conversation
Use validateBuffer to remove duplicate implementation.
Collaborator
|
Review requested:
|
Collaborator
lpinca
approved these changes
Feb 3, 2023
aduh95
approved these changes
Feb 3, 2023
Collaborator
RafaelGSS
approved these changes
Feb 4, 2023
Collaborator
22 tasks
rickyes
approved these changes
Feb 5, 2023
Collaborator
19 tasks
Collaborator
trivikr
approved these changes
Feb 6, 2023
Collaborator
Collaborator
|
Landed in d43b532 |
18 tasks
Contributor
|
This doesn't land cleanly on v19.x-staging, could it please be backported. |
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
Use validateBuffer to remove duplicate implementation. PR-URL: #46489 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use validateBuffer to remove duplicate implementation.