build: sync cares source change - #47359
Merged
Merged
Conversation
Collaborator
|
Review requested:
|
Collaborator
richardlau
approved these changes
Apr 1, 2023
Collaborator
30 tasks
lpinca
approved these changes
Apr 2, 2023
28 tasks
Trott
approved these changes
Apr 3, 2023
Collaborator
29 tasks
Collaborator
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/47359 ✔ Done loading data for nodejs/node/pull/47359 ----------------------------------- PR info ------------------------------------ Title build: sync cares source change (#47359) Author Jiawen Geng (@gengjiawen) Branch gengjiawen:fix_cares -> nodejs:main Labels cares, author ready, needs-ci, dependencies Commits 1 - build: sync cares source change Committers 1 - gengjiawen PR-URL: https://github.com/nodejs/node/pull/47359 Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Rich Trott ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47359 Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Rich Trott -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 01 Apr 2023 08:03:09 GMT ✔ Approvals: 3 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/47359#pullrequestreview-1367841805 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47359#pullrequestreview-1368127356 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/47359#pullrequestreview-1369507051 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2023-04-04T01:56:09Z: https://ci.nodejs.org/job/node-test-pull-request/50890/ - Querying data for job/node-test-pull-request/50890/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4604897824 |
Collaborator
26 tasks
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/47359 ✔ Done loading data for nodejs/node/pull/47359 ----------------------------------- PR info ------------------------------------ Title build: sync cares source change (#47359) Author Jiawen Geng (@gengjiawen) Branch gengjiawen:fix_cares -> nodejs:main Labels cares, author ready, needs-ci, dependencies Commits 1 - build: sync cares source change Committers 1 - gengjiawen PR-URL: https://github.com/nodejs/node/pull/47359 Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Rich Trott ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47359 Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Rich Trott -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 01 Apr 2023 08:03:09 GMT ✔ Approvals: 3 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/47359#pullrequestreview-1367841805 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47359#pullrequestreview-1368127356 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/47359#pullrequestreview-1369507051 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2023-04-04T07:04:31Z: https://ci.nodejs.org/job/node-test-pull-request/50905/ - Querying data for job/node-test-pull-request/50905/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4618985299 |
Collaborator
Collaborator
|
Landed in 0e79635 |
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 13, 2023
PR-URL: #47359 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removed in #46415