Skip to content

tools: update eslint to 8.38.0 - #47475

Closed
nodejs-github-bot wants to merge 2 commits into
mainfrom
actions/tools-update-eslint
Closed

tools: update eslint to 8.38.0#47475
nodejs-github-bot wants to merge 2 commits into
mainfrom
actions/tools-update-eslint

Conversation

@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot commented Apr 8, 2023

Copy link
Copy Markdown
Collaborator

This is an automated update of eslint to 8.38.0.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Apr 8, 2023
@Trott Trott added the commit-queue PRs queued for automated landing through the Commit Queue. label Apr 8, 2023
@aduh95 aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Apr 8, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Apr 10, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 10, 2023

Copy link
Copy Markdown
Collaborator Author
Commit Queue failed
- Loading data for nodejs/node/pull/47475
✔  Done loading data for nodejs/node/pull/47475
----------------------------------- PR info ------------------------------------
Title      tools: update eslint to 8.38.0 (#47475)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     nodejs-github-bot:actions/tools-update-eslint -> nodejs:main
Labels     tools, author ready
Commits    2
 - tools: update eslint to 8.38.0
 - tools: update eslint to 8.38.0
Committers 1
 - Node.js GitHub Bot 
PR-URL: https://github.com/nodejs/node/pull/47475
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Colin Ihrig 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47475
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Colin Ihrig 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - tools: update eslint to 8.38.0
   ℹ  This PR was created on Sat, 08 Apr 2023 00:12:57 GMT
   ✔  Approvals: 4
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/47475#pullrequestreview-1376676617
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47475#pullrequestreview-1376712212
   ✔  - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/47475#pullrequestreview-1376753491
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/47475#pullrequestreview-1376776790
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/4653252632

@nodejs-github-bot nodejs-github-bot added the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Apr 10, 2023
@MoLow MoLow added commit-queue-squash PRs the Commit Queue should land as one squashed commit. commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Apr 10, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Apr 10, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 10, 2023

Copy link
Copy Markdown
Collaborator Author

Landed in 2d1934a...a57b8dd

nodejs-github-bot added a commit that referenced this pull request Apr 10, 2023
@nodejs-github-bot
tools: update eslint to 8.38.0
270e24f 
PR-URL: #47475
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
nodejs-github-bot added a commit that referenced this pull request Apr 10, 2023
@nodejs-github-bot
tools: update eslint to 8.38.0
a57b8dd 
PR-URL: #47475
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@RafaelGSS RafaelGSS mentioned this pull request Apr 11, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 13, 2023
@nodejs-github-bot @RafaelGSS
tools: update eslint to 8.38.0
a58ca61 
PR-URL: #47475
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
RafaelGSS pushed a commit that referenced this pull request Apr 13, 2023
@nodejs-github-bot @RafaelGSS
tools: update eslint to 8.38.0
174662a 
PR-URL: #47475
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@nodejs-github-bot @danielleadams
tools: update eslint to 8.38.0
6ad7e1a 
PR-URL: #47475
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@nodejs-github-bot @danielleadams
tools: update eslint to 8.38.0
77a96d8 
PR-URL: #47475
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@nodejs-github-bot @MoLow
tools: update eslint to 8.38.0
60dc249 
PR-URL: nodejs#47475
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@nodejs-github-bot @MoLow
tools: update eslint to 8.38.0
0a65c7c 
PR-URL: nodejs#47475
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes
@MoLow MoLow MoLow approved these changes
+1 more reviewer
@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@nodejs-github-bot @Trott @lpinca @cjihrig @MoLow @VoltrexKeyva @aduh95