Skip to content

benchmark: refactor crypto oneshot - #48267

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
panva:bench-crypto-oneshots
Jun 5, 2023
Merged

benchmark: refactor crypto oneshot#48267
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
panva:bench-crypto-oneshots

Conversation

@panva

@panva panva commented May 31, 2023 •
edited
Loading

Copy link
Copy Markdown
Member
  • splits a combined sign+verify bench into one for sign, one for verify
  • adds config for other asymmetric key types (rsa, ec, ed25519)
  • adds config for jwk and der key formats
  • skips keyObject.unique configs unless the tested mode is async-parallel

This is the result of my shallow look at nodejs/performance#72

@panva panva added crypto Issues and PRs related to the crypto subsystem. benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels May 31, 2023
@panva panva mentioned this pull request May 31, 2023
Closed
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 1, 2023
@panva

panva commented Jun 1, 2023

Copy link
Copy Markdown
Member Author

cc @nodejs/crypto, also see nodejs/performance#72 (comment)

@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 1, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 1, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52047/

@nodejs-github-bot

nodejs-github-bot commented Jun 1, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52048/

@panva panva added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jun 1, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 1, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52049/

This was referenced Jun 2, 2023
Open
Open
Open
Open
@panva
panva force-pushed the bench-crypto-oneshots branch from 73bcad2 to ac260a8 Compare June 5, 2023 07:49
@panva panva removed the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label Jun 5, 2023
@panva
panva requested a review from tniessen June 5, 2023 09:58
@panva

panva commented Jun 5, 2023

Copy link
Copy Markdown
Member Author

cc @nodejs/performance

anonrig
anonrig reviewed Jun 5, 2023
View reviewed changes
Comment thread benchmark/crypto/oneshot-sign.js Outdated
Comment thread benchmark/crypto/oneshot-sign.js Outdated
Comment thread benchmark/crypto/oneshot-verify.js Outdated
@panva panva added the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 5, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 5, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 0e92bf1 into nodejs:main Jun 5, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 5, 2023

Copy link
Copy Markdown
Collaborator

Landed in 0e92bf1

@panva
panva deleted the bench-crypto-oneshots branch June 5, 2023 19:24
@github-actions github-actions Bot mentioned this pull request Jun 6, 2023
Open
20 tasks
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@panva @RafaelGSS
benchmark: refactor crypto oneshot
12fa716 
PR-URL: #48267
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@panva @Ceres6
benchmark: refactor crypto oneshot
075c508 
PR-URL: nodejs#48267
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@panva @Ceres6
benchmark: refactor crypto oneshot
ec16169 
PR-URL: nodejs#48267
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
ruyadorno pushed a commit that referenced this pull request Aug 29, 2023
@panva @ruyadorno
benchmark: refactor crypto oneshot
4f74be3 
PR-URL: #48267
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@ruyadorno ruyadorno mentioned this pull request Aug 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes
@tniessen tniessen Awaiting requested review from tniessen

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. crypto Issues and PRs related to the crypto subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@panva @nodejs-github-bot @anonrig @tniessen