Skip to content

deps: update undici to 6.15.0 - #52763

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
KhafraDev:update-undici
May 2, 2024
Merged

deps: update undici to 6.15.0#52763
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
KhafraDev:update-undici

Conversation

@KhafraDev

Copy link
Copy Markdown
Member

Updates undici to v6.15.0 by running tools/dep_updaters/update-undici.sh and fixes test failures.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run. labels Apr 30, 2024

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina

Copy link
Copy Markdown
Member

linter is failing

@KhafraDev

Copy link
Copy Markdown
Member Author

the tests should also pass once undici is updated again since the error messages were slightly improved

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label May 1, 2024
@github-actions github-actions Bot added request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. and removed request-ci Add this label to start a Jenkins CI on a PR. labels May 1, 2024
@github-actions

github-actions Bot commented May 1, 2024

Copy link
Copy Markdown
Contributor
Failed to start CI
   ⚠  Something was pushed to the Pull Request branch since the last approving review.
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/8907550593

@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label May 1, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 1, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@mcollina mcollina added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. and removed needs-ci PRs that need a full CI run. request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. labels May 2, 2024
@panva panva added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label May 2, 2024
@mcollina

mcollina commented May 2, 2024

Copy link
Copy Markdown
Member

This needs to wait 9 more hours to land

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 2, 2024
@nodejs-github-bot
nodejs-github-bot merged commit ae8a5ff into nodejs:main May 2, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in ae8a5ff

@KhafraDev
KhafraDev deleted the update-undici branch May 15, 2024 15:38
targos pushed a commit that referenced this pull request Jun 1, 2024
PR-URL: #52763
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jun 7, 2024
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
PR-URL: #52763
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
PR-URL: nodejs#52763
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
PR-URL: #52763
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. dependencies PRs that add, update, or configure Node.js dependencies.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants