Skip to content

doc: exclude commits with baking-for-lts - #52896

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
marco-ippolito:fix/baking-for-lts
May 10, 2024
Merged

doc: exclude commits with baking-for-lts#52896
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
marco-ippolito:fix/baking-for-lts

Conversation

@marco-ippolito

@marco-ippolito marco-ippolito commented May 8, 2024

Copy link
Copy Markdown
Member

Add baking-for-lts to the exclude label

cc @nodejs/releasers

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label May 8, 2024
Comment thread doc/contributing/releases.md Outdated
@aduh95

aduh95 commented May 8, 2024

Copy link
Copy Markdown
Contributor

Is there a way to still include those commits if they have been on Current for long enough?

@marco-ippolito

Copy link
Copy Markdown
Member Author

Is there a way to still include those commits if they have been on Current for long enough?

remove the label

@marco-ippolito marco-ippolito added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label May 8, 2024

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@UlisesGascon UlisesGascon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marco-ippolito marco-ippolito added the commit-queue PRs queued for automated landing through the Commit Queue. label May 8, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 10, 2024
@nodejs-github-bot
nodejs-github-bot merged commit dee061a into nodejs:main May 10, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in dee061a

targos pushed a commit that referenced this pull request May 11, 2024
PR-URL: #52896
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
marco-ippolito added a commit that referenced this pull request Jun 17, 2024
PR-URL: #52896
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
PR-URL: nodejs#52896
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants