Skip to content

src: avoid strcmp in favor of operator== - #53439

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:src-avoid-strcmp
Jun 13, 2024
Merged

src: avoid strcmp in favor of operator==#53439
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:src-avoid-strcmp

Conversation

@tniessen

Copy link
Copy Markdown
Member

No description provided.

@tniessen tniessen added c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs proposed for a shorter-than-standard waiting period before landing. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 13, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @tniessen. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Jun 13, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 13, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@anonrig anonrig added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Jun 13, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 13, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 2bb39f8 into nodejs:main Jun 13, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 2bb39f8

targos pushed a commit that referenced this pull request Jun 20, 2024
PR-URL: #53439
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
PR-URL: nodejs#53439
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
PR-URL: #53439
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants