Skip to content

deps: fix sign-compare warning in ncrypto - #54624

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
zcbenz:fix-ncrypto-warning
Aug 31, 2024
Merged

deps: fix sign-compare warning in ncrypto#54624
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
zcbenz:fix-ncrypto-warning

Conversation

@zcbenz

@zcbenz zcbenz commented Aug 29, 2024

Copy link
Copy Markdown
Contributor

Fix following warning in GN build:

../../node/deps/ncrypto/ncrypto.cc:1197:12: error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Werror,-Wsign-compare]
 1197 |   if (size < dp.size()) {
      |       ~~~~ ^ ~~~~~~~~~

@nodejs-github-bot

nodejs-github-bot commented Aug 29, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run. labels Aug 29, 2024
@anonrig
anonrig requested a review from jasnell August 29, 2024 00:40
@zcbenz zcbenz added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 29, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 29, 2024
@nodejs-github-bot

nodejs-github-bot commented Aug 29, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61624/

@nodejs-github-bot

nodejs-github-bot commented Aug 30, 2024 •
edited by jakecastelli
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61682/ 💚

@zcbenz zcbenz added commit-queue PRs queued for automated landing through the Commit Queue. and removed needs-ci PRs that need a full CI run. labels Aug 31, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 31, 2024
@nodejs-github-bot
nodejs-github-bot merged commit d6f5234 into nodejs:main Aug 31, 2024
@nodejs-github-bot

nodejs-github-bot commented Aug 31, 2024

Copy link
Copy Markdown
Collaborator

Landed in d6f5234

@zcbenz
zcbenz deleted the fix-ncrypto-warning branch August 31, 2024 02:11
aduh95 pushed a commit that referenced this pull request Sep 12, 2024
@zcbenz @aduh95
deps: fix sign-compare warning in ncrypto
6a32645 
PR-URL: #54624
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
Merged
npaun pushed a commit to npaun/ncrypto that referenced this pull request Sep 18, 2025
@zcbenz @npaun
deps: fix sign-compare warning in ncrypto
dd8c696 
PR-URL: nodejs/node#54624
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@anonrig anonrig anonrig approved these changes
@atlowChemi atlowChemi atlowChemi approved these changes

Assignees

No one assigned

Labels

dependencies PRs that add, update, or configure Node.js dependencies.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zcbenz @nodejs-github-bot @jasnell @anonrig @atlowChemi @targos