-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
http: improve performance by removing async_hooks #57938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Review requested:
|
ee036b5
to
7dfbf7e
Compare
I marked this as semver major. While I agree that HTTP parser itself is not async HTTP requests are. As a result I'm fine to the change of http parser itself but the async hooks functionality itself should preserved on HTTP request level otherwise then. |
@Flarna have you verified that it's still relevant with the AsyncContextFrame-backed AsyncLocalStorage? I have a feeling it might not matter anymore, but not 100% certain about that. 🤔 |
No, I haven't verified this. Basically this reverts fixes done a while ago (#27477 and #25094) to prepare HTTP for a better Could be that AsyncContextFrame-backed In the end we don't know as there are no test (ref: #55712 - I thought I find some more time to add tests...). |
Created #58017 to add at least one more test for ALS + HTTP. At the moment this branch doesn't build so couldn't do any local testing. As it is in draft state this is fine and there is no need to hurry anyway. |
Reopening this from #57746.