sqlite,doc: add setReturnArrays missing docs #59074
Merged
+13
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
doc
geeksilva97
commented
Jul 15, 2025
geeksilva97
requested review from
RafaelGSS,
marco-ippolito,
gurgunday and
cjihrig
RafaelGSS
added
dont-land-on-v20.x
I think so. When I look into the v22.x branch, I can see the code there https://github.com/nodejs/node/blob/v22.x/src/node_sqlite.cc#L2313 |
geeksilva97
removed
the
dont-land-on-v22.x
geeksilva97
force-pushed
the
add-missing-sqlite-documentation
branch
from
4782318 to
0438ffb
Compare
geeksilva97
commented
Jul 15, 2025
|
We will want this to land on v22. Should I open the backport now? |
|
Link is complaining about the hardcoded version, but I think that's expected and acceptable in this case. |
Yes, please. |
atlowChemi
approved these changes
Jul 15, 2025
Okay, so I will land this, and open the backport. |
lpinca
approved these changes
Jul 15, 2025
geeksilva97
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/59074 ✔ Done loading data for nodejs/node/pull/59074 ----------------------------------- PR info ------------------------------------ Title sqlite,doc: add setReturnArrays missing docs (#59074) Author Edy Silva <[email protected]> (@geeksilva97) Branch geeksilva97:add-missing-sqlite-documentation -> nodejs:main Labels doc, author ready, dont-land-on-v20.x, sqlite Commits 1 - sqlite,doc: add setReturnArrays missing docs Committers 1 - Edy Silva <[email protected]> PR-URL: https://github.com/nodejs/node/pull/59074 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/59074 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 15 Jul 2025 04:39:53 GMT ✔ Approvals: 2 ✔ - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/59074#pullrequestreview-3021255071 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/59074#pullrequestreview-3022278719 ✘ Last GitHub CI failed ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/16336439008 |
gurgunday
approved these changes
Jul 17, 2025
|
Landed in ee1ec50 |
aduh95
added
backport-open-v22.x
aduh95
pushed a commit
to geeksilva97/node
that referenced
this pull request
Jul 17, 2025
PR-URL: nodejs#59074 Refs: nodejs#57542 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Jul 17, 2025
PR-URL: #59074 Refs: #57542 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
StatementSync.prototype.setReturnArrayswas introduced a few months ago but its documentation was not added.This PR adds such a documentation.
Refs: #57542