Skip to content

Fix repl history callback error #60903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix repl history callback error #60903

wants to merge 4 commits into from
+66 −39

Conversation

@wcr-karan
Copy link

@wcr-karan wcr-karan commented Nov 30, 2025

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. labels Nov 30, 2025
@aduh95
Copy link
Contributor

aduh95 commented Nov 30, 2025

You need to include a test that fails on main and passes with your changes

@wcr-karan
Copy link
Author

wcr-karan commented Nov 30, 2025

This PR fixes issue #60837.

Problem:
replServer.setupHistory() was swallowing errors thrown inside the callback starting from Node v24.2.0.

Fix:
Propagate errors thrown in the setupHistory callback and ensure they are correctly handled.

Added a test in:
test/parallel/test-repl-setup-history-error.js
to ensure the error is not swallowed.

@aduh95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wcr-karan @aduh95 @nodejs-github-bot