Skip to content

test: improve config-file permission test coverage #60929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: improve config-file permission test coverage #60929

wants to merge 1 commit into from
+70 −39

Conversation

@RafaelGSS
Copy link
Member

@RafaelGSS RafaelGSS commented Dec 1, 2025

@RafaelGSS RafaelGSS added the permission Issues and PRs related to the Permission Model label Dec 1, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 1, 2025

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Dec 1, 2025
@codecov
Copy link

codecov bot commented Dec 1, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.41%. Comparing base (28142a6) to head (13688a0).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #60929      +/-   ##
==========================================
+ Coverage   88.00%   88.41%   +0.40%     
==========================================
  Files         703      703              
  Lines      208394   208375      -19     
  Branches    40103    40117      +14     
==========================================
+ Hits       183403   184228     +825     
+ Misses      16940    16140     -800     
+ Partials     8051     8007      -44

see 112 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 2, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 2, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 2, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70369/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 2, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70371/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 3, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70375/

@marco-ippolito marco-ippolito added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. config Issues or PRs related to the config subsystem labels Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees

No one assigned

Labels

config Issues or PRs related to the config subsystem dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RafaelGSS @nodejs-github-bot @marco-ippolito