Skip to content

build: sync cargo/rustc version warnings - #65912

Open
richardlau wants to merge 1 commit into
nodejs:mainfrom
richardlau:configurerust
Open

build: sync cargo/rustc version warnings#65912
richardlau wants to merge 1 commit into
nodejs:mainfrom
richardlau:configurerust

Conversation

@richardlau

@richardlau richardlau commented Sep 8, 2026

Copy link
Copy Markdown
Member

The version checks in configure.py were not updated when the minimum rustc requirement was bumped to 1.86 for temporal_rs 0.2.3.

Refs: #64543

@richardlau
build: sync cargo/rustc version warnings
420b0e8 
The version checks in `configure.py` were not updated when the minimum
rustc requirement was bumped to 1.86 for temporal_rs 0.2.3.

Signed-off-by: Richard Lau <richard.lau@ibm.com>
@richardlau richardlau added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Sep 8, 2026
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. labels Sep 8, 2026
@richardlau

richardlau commented Sep 8, 2026

Copy link
Copy Markdown
Member Author

We're going to bump the version again in #65742, but we should synchronize the warning threshold with the existing requirement so it can land on v26.x (the other PR is for Node.js 27).

@richardlau richardlau mentioned this pull request Sep 8, 2026
Open
@Renegade334 Renegade334 added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Sep 8, 2026
@Renegade334 Renegade334 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Sep 8, 2026
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Renegade334. Please 👍 to approve.

@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 8, 2026
@nodejs-github-bot

nodejs-github-bot commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/77195/

panva
panva approved these changes Sep 8, 2026
View reviewed changes

@panva panva left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rslgtm

@MikeMcC399

This comment was marked as outdated.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panva panva panva approved these changes
@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
@Renegade334 Renegade334 Renegade334 approved these changes
@MikeMcC399 MikeMcC399 MikeMcC399 approved these changes

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@richardlau @nodejs-github-bot @MikeMcC399 @panva @jasnell @lpinca @Renegade334