src: fix FreeEnvironment() breaking JS in sibling Environments - #65977
Open
codebytere wants to merge 1 commit into
Open
src: fix FreeEnvironment() breaking JS in sibling Environments#65977codebytere wants to merge 1 commit into
codebytere wants to merge 1 commit into
Conversation
`FreeEnvironment()` forbids JavaScript on the whole isolate with a `DisallowJavascriptExecutionScope` and then spins the event loop in `Environment::CleanupHandles()` until its handles are closed. When the loop and isolate are shared with other Environments, as they are for an embedder hosting several Environments on one thread, those loop turns also run the other Environments' timers and I/O callbacks, and every one of them failed with an "illegal access" exception thrown into unrelated code. While an Environment is closing its handles, let `InternalCallbackScope` re-allow JavaScript for callbacks of Environments that can still call into JS. The Environment being freed stays blocked: its callbacks fail the `can_call_into_js()` check before that point, and anything that bypasses `InternalCallbackScope` (V8 foreground tasks, raw addon callbacks) still runs under the disallow scope. Refs: nodejs#33874 Refs: nodejs#65819 Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65977 +/- ##
=======================================
Coverage 90.17% 90.18%
=======================================
Files 771 771
Lines 265470 265473 +3
Branches 50463 50465 +2
=======================================
+ Hits 239383 239412 +29
+ Misses 17055 17001 -54
- Partials 9032 9060 +28
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When several Environments share one isolate and event loop (an embedder hosting them on one thread), calling
FreeEnvironment()on one of them throws "illegal access" into the others' timers and I/O callbacks:FreeEnvironment()forbids JavaScript on the whole isolate with aDisallowJavascriptExecutionScopeand then spins the shared loop inEnvironment::CleanupHandles()until its own handles close, and those loop turns also run the siblings' callbacks.While an Environment is closing its handles,
InternalCallbackScopenow re-allows JavaScript for callbacks whose own Environment can still call into JS. The Environment being freed stays blocked: its callbacks fail thecan_call_into_js()check before that point, and anything that bypassesInternalCallbackScope(V8 foreground tasks, raw addon callbacks) still runs under the disallow scope.Tests:
EnvironmentTest.FreeEnvironmentWhileSiblingHasActiveHandlesfrees one Environment while a sibling's interval is running and checks the sibling keeps ticking; it threw before.Refs: #33874
Refs: #65819
Disclosure: the code, test and this description were written by Claude Code, directed and reviewed by @codebytere.