Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
force-pushed
the
fix-quic-detection
branch
from
September 28, 2026 08:26
2df3498 to
7c0bcaa
Compare
ngtcp2 and nghttp3 detectionHAVE_QUIC macro in favor of OPENSSL_NO_QUIC
jasnell
approved these changes
Sep 28, 2026
jasnell
left a comment
Member
There was a problem hiding this comment.
Oh, nice. I'd been meaning to clean that up for ages but managed to keep forgetting.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66373 +/- ##
==========================================
- Coverage 90.37% 90.36% -0.01%
==========================================
Files 792 792
Lines 275426 275426
Branches 52800 52776 -24
==========================================
- Hits 248926 248899 -27
- Misses 16931 16944 +13
- Partials 9569 9583 +14
🚀 New features to boost your workflow:
|
panva
approved these changes
Sep 28, 2026
This comment has been minimized.
This comment has been minimized.
marco-ippolito
approved these changes
Sep 28, 2026
Contributor
Failed to resume CIFull Auto Start CI output |
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use both
OPENSSL_NO_QUICandHAVE_QUICto gate QUIC code in C++, getting rid of the latter seems to make the most sense