Skip to content

Remove extra semicolons. - #2484

Merged
1 commit merged into
nodejs:masterfrom
XhmikosR:xmr-semi
Sep 3, 2019
Merged

1 commit merged into
nodejs:masterfrom
XhmikosR:xmr-semi

Conversation

@XhmikosR

@XhmikosR XhmikosR commented Sep 2, 2019

Copy link
Copy Markdown
Contributor

'build.js' has extra semicolons, remove them together.

@Trott

Trott commented Sep 2, 2019

Copy link
Copy Markdown
Member

standard --fix which runs on npm t doesn't fail if it can fix the issues. This is another reason to separate the npm scripts...

Wand to include the fix to package.json here as a second commit so that more things like this don't creep in?

@XhmikosR

XhmikosR commented Sep 2, 2019

Copy link
Copy Markdown
Contributor Author

@Trott I believe this should be handled in a separate PR, see #2463. It's already pretty troublesome developing, let alone that we have npm t in a precommit hook which slows down things a lot...

@ghost
ghost merged commit 4936031 into nodejs:master Sep 3, 2019
@XhmikosR
XhmikosR deleted the xmr-semi branch September 3, 2019 04:38
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants