Skip to content

meta: upgrade to next.js 16 #8218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

meta: upgrade to next.js 16 #8218

wants to merge 2 commits into from
+607 −536

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Oct 11, 2025

This PR is a draft PR for upgrading to Next.js 16.

  • Development Server Works
  • Production Build fails
❯ pnpm build

> @node-core/website@ prebuild /home/cwunder/GitHub/nodejs.org/apps/site
> node --run build:blog-data


> @node-core/website@ build /home/cwunder/GitHub/nodejs.org/apps/site
> node --run build:default -- --turbopack

   ▲ Next.js 16.0.0-beta.0 (Turbopack)
   - Experiments (use with caution):
     ✓ globalNotFound
     · optimizePackageImports
     ✓ parallelServerBuildTraces
     ✓ parallelServerCompiles
     ✓ turbopackFileSystemCacheForDev
     ✓ webpackBuildWorker

   Creating an optimized production build ...
 ✓ Compiled successfully in 5.1s
   Skipping validation of types
 ✓ Collecting page data in 654ms    
Error occurred prerendering page "/404". Read more: https://nextjs.org/docs/messages/prerender-error
Error [PageNotFoundError]: Cannot find module for page: /_document
    at ignore-listed frames {
  code: 'ENOENT'
}
Export encountered an error on /_error: /404, exiting the build.
 ⨯ Next.js build worker exited with code: 1 and signal: null
 ELIFECYCLE  Command failed with exit code 1.

@vercel Vercel
Copy link

vercel bot commented Oct 11, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Error Error Oct 11, 2025 0:52am

@codecov Codecov
Copy link

codecov bot commented Oct 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.20%. Comparing base (089e65c) to head (f2ade22).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8218      +/-   ##
==========================================
- Coverage   76.66%   75.20%   -1.46%     
==========================================
  Files         115      115              
  Lines        9623     9623              
  Branches      322      317       -5     
==========================================
- Hits         7377     7237     -140     
- Misses       2245     2385     +140     
  Partials        1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AugustinMauroy
AugustinMauroy reviewed Oct 11, 2025
View reviewed changes
apps/site/app/global-not-found.tsx
import GlowingBackdropLayout from '#site/layouts/GlowingBackdrop';

const NotFoundPage: FC = () => (
<html>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<html>
<html lang="en">

@ovflowd
Copy link
Member Author

ovflowd commented Oct 12, 2025

cc @styfle any idea what the prod build failing could be? Pretty much using standard error pages 🤔

@icyJoseph
Copy link

icyJoseph commented Oct 14, 2025 •
edited
Loading

Hi, I haven't fully sorted this out, but I managed to get a "bad" passing build. This was my only attempt and the order of steps was a bit chaotic, so not as linearly as presented here.

I used the --debug-prerender flag on next build, and followed the trace from there.

With that flag I started to see:

Error occurred prerendering page "/_not-found". Read more: https://nextjs.org/docs/messages/prerender-error
@node-core/website:build: Error: 
@node-core/website:build:     at WithNavBar (turbopack:///[project]/apps/site/components/withNavBar.tsx:43:31)
@node-core/website:build:   41 |   const { resolvedTheme, setTheme } = useTheme();
@node-core/website:build:   42 |   const { replace } = useRouter();
@node-core/website:build: > 43 |   const pathname = usePathname();
@node-core/website:build:      |                               ^

All of the errors reported, pointed at the group of next-intl helpers, Link, usePathname, useRouter from app/site/navigation.mjs - note that I am not claiming a bug on next-intl.

useLocale and useTranslations were also lifted by --debug-prerender.

After replacing the helpers with their original Next.js version, and replacing useLocale() with a string and useTranslations with a dummy function. I hit one more error, /pages somehow requiring _document to be present. To get around this, I renamed the folder pages to _pages and then edited next.dynamic.mjs file to read from _pages:

 const websitePages = await getMarkdownFiles(
    process.cwd(),
    `_pages/${defaultLocale.code}`
  );

With all of that...

Screenshot 2025-10-13 at 22 55 00

I think the path generation is somehow causing all of these to error. At this point, I do not think that we need to change pages to _pages necessarily. It is just a coincident I believe.

Also I am not familiar enough with this repo, so maybe I am building with the wrong .envs.

Note that https://github.com/amannn/next-intl/tree/main/examples/example-app-router w/ next@beta builds without errors too.

Hopefully this gives you some insight. Happy to keep on helping!

@ovflowd
Copy link
Member Author

ovflowd commented Oct 14, 2025

I think the path generation is somehow causing all of these to error. At this point, I do not think that we need to change pages to _pages necessarily. It is just a coincident I believe.

Sounds like a bug on Next.js imo

All of the errors reported, pointed at the group of next-intl helpers, Link, usePathname, useRouter from app/site/navigation.mjs - note that I am not claiming a bug on next-intl.

Could be that next-intl needs to upgrade to be compatible with Next.js 16? cc @amannn

@icyJoseph
Copy link

Most likely a Next.js thing yeah ~ I'll try to set some time apart later, to try and build by bisecting canaries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AugustinMauroy AugustinMauroy AugustinMauroy left review comments

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ovflowd @icyJoseph @AugustinMauroy