-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add configurable request body size limit option #380
Conversation
thanks for the PR, mind adding a test for this new feature? |
package.json
Outdated
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "faas-js-runtime", | |||
"version": "2.4.1", | |||
"version": "2.5.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for this in the PR, we have some automation that will update the version when we do the release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed version bump
looks like the tests are fine, but it's failing on uploading codecoverage. I fixed that in this issue #381 , would you mind doing a quick rebase? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for the PR
feat: Add configurable request body size limit option
Description
Adds a new
--bodyLimit
CLI option and configuration parameter to control the maximum allowed HTTP request payload size in the faas-js-runtime.Changes
--bodyLimit
CLI option to set maximum request payload sizeFUNC_BODY_LIMIT
environment variable supportExample Usage
Technical Details