Skip to content

Conversation

charlie-tori
Copy link
Contributor

feat: export Models to init.py so that its client can import it conveniently

Please note that there is a name conflict so that I has renamed
GetConversationsRequest -> GetConversationsListRequest in dify_oapi/api/chat/v1/model/get_conversation_list_request.py

Also, the input type of Dify chatflow request is not just dict[str, str] but maybe dict[str, dict] (in case of file input) so I changed it type to dict[str, Any]

@Oscaner
Copy link
Member

Oscaner commented Oct 9, 2025

Hi @charlie-tori ,

Thanks to do it.
Others fine for me. But can we not use the Any type? Because it's too blurred.

We can define special model, such as WorkflowInputValue.
Or if haven't enough time, please add a TODO annotation for it, this is ok.

@Oscaner Oscaner changed the base branch from main to develop October 9, 2025 03:54
@charlie-tori
Copy link
Contributor Author

Hi @Oscaner, since I can’t provide a comprehensive value type for the input values and I’m quite busy at the moment, I’ve added a TODO comment. I’ll continue using the library and contributing to it. Thank you.

@Oscaner
Copy link
Member

Oscaner commented Oct 10, 2025

Hi @charlie-tori ,

Okay, thanks. LGTM.

@Oscaner Oscaner merged commit eaef899 into nodite:develop Oct 10, 2025
1 check passed
@Oscaner
Copy link
Member

Oscaner commented Oct 10, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants