feat: core architecture improvements #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esting major restructure with client-server architecture, comprehensive testing, and improved error handling
- Change UpdateConfig to use PATCH method as expected by Caddy API - Fix domain validation to reject localhost and follow RFC standards - Update test expectations to match implementation behavior - Remove obsolete build.yaml workflow
- Update golangci-lint config for newer version compatibility - Add missing comments for exported constants - Fix formatting with gofumpt - Address security warnings with proper annotations - Fix unused parameter warnings - Use more restrictive directory permissions (0750)
- Refactor RemoveServerBlock to reduce cyclomatic complexity - Fix evalOrder warning in spinner Update method - Remove unused parameters in registerMDNS and NewConnectionPool - Remove unnecessary error return from GetClientTLSConfig - Extract helper methods for better code organization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major refactoring with improved security and efficiency