-
Notifications
You must be signed in to change notification settings - Fork 18
Implement Rope::is_instance()
#11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
truchi
wants to merge
1
commit into
nomad:main
Choose a base branch
from
truchi:is_instance
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -436,6 +436,27 @@ impl Rope { | |
| is_grapheme_boundary(self.chunks(), self.byte_len(), byte_offset) | ||
| } | ||
|
|
||
| /// Returns true if this rope and `other` point to precisely the same | ||
| /// in-memory data. | ||
| /// | ||
| /// This happens when one of the ropes is a clone of the other and | ||
| /// neither have been modified since then. Because clones initially | ||
| /// share all the same data, it can be useful to check if they still | ||
| /// point to precisely the same memory as a way of determining | ||
| /// whether they are both still unmodified. | ||
| /// | ||
| /// Note: this is distinct from checking for equality: two ropes can | ||
| /// have the same *contents* (equal) but be stored in different | ||
| /// memory locations (not instances). Importantly, two clones that | ||
| /// post-cloning are modified identically will *not* be instances | ||
| /// anymore, even though they will have equal contents. | ||
| /// | ||
| /// Runs in O(1) time. | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This time complexity can be removed since none of the other methods mention theirs. |
||
| #[inline] | ||
| pub fn is_instance(&self, other: &Self) -> bool { | ||
| self.tree.is_instance(&other.tree) | ||
| } | ||
|
|
||
| /// Returns the line at `line_index`, without its line terminator. | ||
| /// | ||
| /// If you want to include the line break consider taking a | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be consistent w/ all the other public methods we should add an
# Examplessection to show in code how this works.