Skip to content

Make TreeSlice::offset a L::BaseMetric instead of a full L::Summary #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
noib3 merged 35 commits into from
Aug 14, 2025
Merged

Make TreeSlice::offset a L::BaseMetric instead of a full L::Summary #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
86a4775
Tweak `Add*` and `Sub*` requirements on `Summary`
noib3 Aug 13, 2025
581cdfb
Tweak
noib3 Aug 13, 2025
8bb3e78
WIP
noib3 Aug 13, 2025
e857142
WIP
noib3 Aug 13, 2025
0d515c3
WIP
noib3 Aug 13, 2025
4545bbb
WIP
noib3 Aug 13, 2025
96ca83b
WIP
noib3 Aug 13, 2025
9d20a3a
Make `TreeSlice::offset` a `BaseMetric` instead of a full `Summary`
noib3 Aug 13, 2025
4761777
Use `summary.measure::<M>()` instead of `M::measure(&summary)`
noib3 Aug 13, 2025
c2bf994
Reduce `Summary`'s requirements to `{Add,Sub}Assign`
noib3 Aug 13, 2025
0501b7e
Relax `PartialEq`'s requirement for `Summary`
noib3 Aug 13, 2025
42b50ee
Add `Summary::empty()` instead of bounding it to `Default`
noib3 Aug 13, 2025
ad49c58
Tweaks
noib3 Aug 13, 2025
01cd50d
Update docs
noib3 Aug 13, 2025
69d4d1f
Tweak wording
noib3 Aug 13, 2025
dc87c68
Remove wrong assertion
noib3 Aug 13, 2025
33f94cb
Use seedable RNG in randomized tests
noib3 Aug 13, 2025
1977524
Fix bug
noib3 Aug 13, 2025
fb3eab8
Fix assertion
noib3 Aug 13, 2025
56cb1fa
Tweaks
noib3 Aug 13, 2025
9fc7d94
WIP
noib3 Aug 14, 2025
3af5311
Add a `FromMetric` trait for converting metrics without slicing
noib3 Aug 14, 2025
cec5452
Add `GapBufferSummary`, make `ChunkSummary` a `Summary` of `str`s
noib3 Aug 14, 2025
ebb0b48
Rename `ChunkSummary` to `StrSummary`
noib3 Aug 14, 2025
f5c7ead
Prefer `str.summarize()` over `StrSummary::from(str)`
noib3 Aug 14, 2025
0a4000d
Prefer `StrSummary::empty()` over `StrSummary::new()`
noib3 Aug 14, 2025
2e8fa5f
Avoid the need for `Node::convert_measure_from_offset()`
noib3 Aug 14, 2025
786da19
Prefer "length" over "measure"
noib3 Aug 14, 2025
5c56ec6
Seed random tests from `u64`
noib3 Aug 14, 2025
6353e5d
Fix bug
noib3 Aug 14, 2025
3981d91
Avoid the need for a separate `TreeSlice::slice_node_at_offset()` fun…
noib3 Aug 14, 2025
610478c
Fix bug
noib3 Aug 14, 2025
a1cf465
Tweaks
noib3 Aug 14, 2025
55583c3
Require `M::one()` only for `UnitMetric`s
noib3 Aug 14, 2025
2f9c2ce
Fix bug
noib3 Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ unicode-segmentation = { version = "1.10.0", optional = true }
[dev-dependencies]
criterion = "0.7"
rand = "0.9"
rand_chacha = "0.9"
ropey = "1.6"
serde_json = "1"
serde_test = "1.0.177"
Expand Down
2 changes: 1 addition & 1 deletion src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ pub use rope::{Rope, RopeBuilder, RopeSlice};
pub use rope::{
gap_buffer::GapBuffer,
gap_slice::GapSlice,
metrics::ChunkSummary,
metrics::StrSummary,
};

#[inline]
Expand Down
Loading