This repository was archived by the owner on Sep 21, 2021. It is now read-only.
Conversation
Contributor
jengeb
commented
Aug 27, 2015
- highlighting of navbar item if corresponding page (thus far: home and instances) is active
- replace hard-coded paths with Rails' url helper
- add nav_link_to helper (works out the class internally) (http://stackoverflow.com/questions/3705898/best-way-to-add-current-class-to-nav-in-rails-3/7756320#7756320)
app/views/layouts/_header.html.slim
Outdated
Member
There was a problem hiding this comment.
You can refactor this to use the current_page? helper
http://api.rubyonrails.org/classes/ActionView/Helpers/UrlHelper.html#method-i-current_page-3F
Even better would be to create nav_bar helper that take's the link path and name and works out the class internally see for a nice example: http://solvedstack.com/questions/best-way-to-add-current-class-to-nav-in-rails-3
Let me know if you need any help
Contributor
Author
There was a problem hiding this comment.
Alright I will improve the code having regard to this feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.