nrfx: fix errata7 workaround in nrfx_nvmc_uicr_word_read/write#146
Open
campbellyoung wants to merge 1 commit into
Open
nrfx: fix errata7 workaround in nrfx_nvmc_uicr_word_read/write#146campbellyoung wants to merge 1 commit into
campbellyoung wants to merge 1 commit into
Conversation
|
|
Contributor
|
hi @campbellyoung , thanks for reporting this. We will look into the issue internally and come back to you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The errata 7 workaround is broken in the current state, and it causes issues with NRF Connect SDK 3.2.1.
Symptom: if I read UICR via TF-M, the actual read works fine, but the next time I generate a panic, it will HardFault instead of being handled properly.
I'm not sure specifically WHY this happens, but this patch fixes it, and seems more logically consistent with the actual errata.
Root issue:
NRF_ERRATA_DYNAMIC_CHECKdoes a flash read innrf91_errata_7( when it checksNRF_FICR_S) which happens before the actual memory barrier executes.Pull requests are a little annoying with all the different repos, so I've done the PR here and added a working sample to reproduce the issue below, hope that's fine.
https://github.com/campbellyoung/sdk-nrf/blob/tfm-uicr-panic/samples/crypto/tfm_uicr_panic/