Detect if zip is mfw or application#595
Open
SlavaNordic wants to merge 2 commits into
Open
Conversation
This comment has been minimized.
This comment has been minimized.
SlavaNordic
added
doc required
greg-fer
requested changes
Jun 23, 2026
| {isApplication | ||
| ? 'application programming' | ||
| : 'modem DFU'}{' '} | ||
| via MCUboot. |
Contributor
There was a problem hiding this comment.
Suggested change
| via MCUboot. | |
| using MCUboot. |
Comment on lines
292
to
293
| The device will be overwritten if you proceed to | ||
| write. |
Contributor
There was a problem hiding this comment.
Suggested change
| The device memory will be overwritten if you proceed to | |
| write. |
| write. | ||
| </p> | ||
| <p className="tw-mb-0"> | ||
| Make sure the device is in{' '} |
Contributor
There was a problem hiding this comment.
Suggested change
| Make sure the device is in the{' '} |
kylebonnici
requested changes
Jun 25, 2026
| if (isModem) return FirmwareType.MODEM; | ||
|
|
||
| // Is Application: check manifest.json with a "file" entry of type "application". | ||
| const manifestEntry = directory.files.find(file => |
Contributor
There was a problem hiding this comment.
I would consider moving the application check before the modem check as FW with 'manifest.json' is still an application FW even if it named to match /(^|\/)mfw_nrf\w+/.test(l)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://nordicsemi.atlassian.net/browse/NCD-1694