Add bb tasks and update deps #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norton
force-pushed
the
feature/update-deps
branch
4 times, most recently
from
1c84022 to
a402960
Compare
norton
force-pushed
the
feature/update-deps
branch
from
a402960 to
1fdb0f6
Compare
eliascotto
suggested changes
Nov 13, 2023
src/app/tutorial.cljs
Outdated
| @@ -1,7 +1,7 @@ | |||
| (ns app.tutorial | |||
| (:require | |||
| [clojure.string :as string] | |||
| [sci.impl.vars :refer [SciVar]])) | |||
| [sci.impl.vars :refer [IVar]])) | |||
There was a problem hiding this comment.
In the new version of sci SciVar has been removed, IVar is something else.
I found that here we can require instead [sci.lang :refer [Var]] and use it for testing afterwards.
There was a problem hiding this comment.
@eliascotto Thank you for the correction - updated.
src/app/tutorial.cljs
Outdated
| Create a global variable called `foo` with a value. E.g. `(def foo \"bar\")`" | ||
| :test #(and (instance? SciVar %) (= "foo" (-> (.-meta %) :name str)))} | ||
| :test #(and (instance? IVar %) (= "foo" (-> (.-meta %) :name str)))} |
There was a problem hiding this comment.
Here the test should now check for Var instead (instance? Var %).
There was a problem hiding this comment.
@eliascotto Thank you for the correction - updated.
norton
force-pushed
the
feature/update-deps
branch
from
93d22e5 to
6f2c309
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add bb tasks and update deps