-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust size and positioning of some diacritics #252
base: main
Are you sure you want to change the base?
Adjust size and positioning of some diacritics #252
Conversation
Looks OK to me - @khaledhosny WDYT? |
Adjust the position of the Dot.
Adjust the position of the Dot.
Adjust the position of the Dot.
Thank you for reviewing this pull request. I have adjusted the three components pointed out by @khaledhosny and would appreciate your confirmation. I'm also grateful for highlighting the vowel marks that may need adjustment to maintain consistency with the components modified in this pull request. Upon examining some of the vowel marks @khaledhosny mentioned, it appears that some were originally large and may not require adjustment. For example, vowel marks like doublerightarrowheadabove-ar and doublerightarrowheadDotabove-ar seem larger than Sukun and Fatha. Considering these points, I would like to inquire about your opinion on whether this pull request can be merged at this time. Or, would you prefer that I review the vowel marks @khaledhosny mentioned, make any necessary adjustments, and submit a new pull request? I would appreciate your feedback on this matter. |
Hello. Thank you for providing us with great fonts.
I'd like to submit a pull request for Noto Naskh Arabic.
The target is the following issue.
#241
Thank you for taking this request into consideration.
@YusukeShirakihara : Thank you very much for your significant contributions and cooperation to this pull request!