Conversation
Contributor
|
We're going to stick with the default setting of Trusty/14.04 LTS. |
Author
|
@aeschright Can I ask why? |
Contributor
We want to stick to the simplest config so there are few surprises. We'll switch when the default CI environment migrates. |
Author
|
@aeschright I see. That's also reasonable. |
This was referenced Oct 22, 2024
Jah-yee
pushed a commit
to Jah-yee/cli
that referenced
this pull request
Apr 16, 2026
The reject_control_chars helper rejected bytes 0x00-0x1F but allowed the DEL character (0x7F), which is also an ASCII control character. This could allow malformed input from LLM agents to bypass validation.
github-actions Bot
added a commit
to Kevinlee7250/cli
that referenced
this pull request
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the test environment from Ubuntu 14.04.5 LTS, released at August 4, 2016, to 16.04.5 LTS, released at August 2, 2018.