Skip to content

feat(pkg): add support to empty bracket syntax - #3539

Closed
ruyadorno wants to merge 1 commit into
npm:release-nextfrom
ruyadorno:add-npm-pkg-set-empty-bracket-array-using-symbols
Closed

feat(pkg): add support to empty bracket syntax#3539
ruyadorno wants to merge 1 commit into
npm:release-nextfrom
ruyadorno:add-npm-pkg-set-empty-bracket-array-using-symbols

Conversation

@ruyadorno

@ruyadorno ruyadorno commented Jul 13, 2021

Copy link
Copy Markdown
Contributor

Adds ability to using empty bracket syntax as a shortcut to appending
items to the end of an array when using npm pkg set, e.g:

npm pkg set keywords[]=foo

References

Relates to: npm/rfcs#402

cc @ljharb @darcyclarke

@ruyadorno
ruyadorno requested a review from a team as a code owner July 13, 2021 16:24
@ruyadorno ruyadorno added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release semver:minor new backwards-compatible feature labels Jul 13, 2021
@ruyadorno
ruyadorno force-pushed the add-npm-pkg-set-empty-bracket-array-using-symbols branch from 8d0eae0 to 0a6c68f Compare July 13, 2021 16:27
Comment thread lib/utils/queryable.js Outdated
@ruyadorno
ruyadorno force-pushed the add-npm-pkg-set-empty-bracket-array-using-symbols branch from 0a6c68f to 23147e8 Compare July 13, 2021 17:38
Comment thread lib/utils/queryable.js Outdated
Comment thread lib/utils/queryable.js
@ruyadorno
ruyadorno force-pushed the add-npm-pkg-set-empty-bracket-array-using-symbols branch 3 times, most recently from 76ac9ae to 33ee276 Compare July 13, 2021 20:10
Comment thread lib/utils/queryable.js Outdated
@ruyadorno
ruyadorno force-pushed the add-npm-pkg-set-empty-bracket-array-using-symbols branch from 33ee276 to b43e26b Compare July 13, 2021 21:18
Comment thread lib/utils/queryable.js Outdated
Comment thread lib/utils/queryable.js
@ruyadorno
ruyadorno force-pushed the add-npm-pkg-set-empty-bracket-array-using-symbols branch from b43e26b to 2439bec Compare July 13, 2021 21:56
Comment thread lib/utils/queryable.js Outdated
Adds ability to using empty bracket syntax as a shortcut to appending
items to the end of an array when using `npm pkg set`, e.g:

npm pkg set keywords[]=foo

Relates to: npm/rfcs#402
@ruyadorno
ruyadorno force-pushed the add-npm-pkg-set-empty-bracket-array-using-symbols branch from 2439bec to 486a266 Compare July 14, 2021 14:01
ruyadorno added a commit that referenced this pull request Jul 15, 2021
Adds ability to using empty bracket syntax as a shortcut to appending
items to the end of an array when using `npm pkg set`, e.g:

npm pkg set keywords[]=foo

Relates to: npm/rfcs#402

PR-URL: #3539
Credit: @ruyadorno
Close: #3539
Reviewed-by: @darcyclarke, @ljharb
@ruyadorno

Copy link
Copy Markdown
Contributor Author

Landed in 8371d7d

@ruyadorno ruyadorno closed this Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release semver:minor new backwards-compatible feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants