style: subtle color and size adjustment for <details> in the readme#2392
style: subtle color and size adjustment for <details> in the readme#2392ghostdevv merged 2 commits intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
Hello! Thank you for opening your first PR to npmx, @ayo-run! 🚀 Here’s what will happen next:
|
📝 WalkthroughWalkthroughThis pull request introduces styling enhancements to the Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
app/components/Readme.vue (1)
478-490: LGTM! Correctly implements the subtle styling for details elements.The styling achieves the PR objective:
- Details content is rendered smaller (0.925rem) and with a more subtle colour (
--fg-subtle)- Summary remains at standard size (1rem) and colour (
--fg-muted, matching the base readme text on line 81)The comment clearly explains the font-size choice. The nested CSS syntax is valid and should compile correctly with Vue 3 and modern build tools.
Optional: Consider more explicit selector syntax
For improved clarity, you could use a separate rule instead of nested syntax:
/* Details element */ .readme :deep(details) { /** * same size as [data-level='5'] */ font-size: 0.925rem; color: var(--fg-subtle); +} - summary { - font-size: 1rem; - color: var(--fg-muted); - } +.readme :deep(details summary) { + font-size: 1rem; + color: var(--fg-muted); }The current nested syntax works fine; this is purely a stylistic preference.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 52362977-0f01-40e8-a37d-78734b877aac
📒 Files selected for processing (1)
app/components/Readme.vue
|
Thanks for your first contribution, @ayo-run! ✨ We'd love to welcome you to the npmx community. Come and say hi on Discord! And once you've joined, visit npmx.wamellow.com to claim the contributor role. |
🔗 Linked issue
resolves #2391
🧭 Context
Hello, sorry if I went ahead and fixed this one without discussion first of the issue 😆. It's a small one. This PR will implement a subtle difference in
<details>content.📚 Description
The PR applies a change in how
<details>on the readme of a package is rendered. The<summary>content remains unchanged, while the content hidden/shown when toggling are smaller and subtler. More description on the issue #2391See screenshots
The following are screenshots for the readme of
@ayo-run/mnswpr