Ignore patterns from global gitignore#9
Open
matusf wants to merge 1 commit intonpx:masterfrom
Open
Conversation
Owner
|
Hello @matusf! Thank you for your work! I would appreciate it if you could rebase your changes onto my latest upstream changes. As for the code, I will add some comments! |
matusf
force-pushed
the
1-include-global-gitignore
branch
from
e7bdc1b to
cb4dc01
Compare
Author
|
@npx rebased! |
Owner
|
@matusf can you see the comments I made a while ago? |
Author
|
No, I don't see any of them. |
Author
|
ping @npx |
npx
reviewed
Jan 12, 2021
Author
|
Yes, I see it now, thanks. I'll make the changes shortly. |
matusf
force-pushed
the
1-include-global-gitignore
branch
from
cb4dc01 to
6acd1da
Compare
- add function for expanding paths starting with `~` - add method for getting path to global gitignore from git config
matusf
force-pushed
the
1-include-global-gitignore
branch
from
6acd1da to
3711b35
Compare
Author
|
Hi @npx, I've made the changes. Could you please check if it's all ok? |
|
@npx good enhancement. I would vote to include this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! First of all, thanks for this awesome extension!
I've added a functionality to ignore patterns from global git ignore. I'm sorry if this is not the most idiomatic typescript, I was coding in typescript for the first time 😃 However, I'm happy to follow your review recommendations if you have any.
closes #1