[nrf noup] Add unit tests for west zap commands #667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArekBalysNordic
force-pushed
the
west_zap_unit_tests
branch
5 times, most recently
from
7e35bb8 to
5c782d9
Compare
ArekBalysNordic
force-pushed
the
west_zap_unit_tests
branch
7 times, most recently
from
d833f50 to
467e2e4
Compare
kkasperczyk-no
approved these changes
Nov 21, 2025
ArekBalysNordic
force-pushed
the
west_zap_unit_tests
branch
3 times, most recently
from
4f358ba to
a7af490
Compare
- Now the zcl.json contains the rules for zap-tool that are used with generating a zap file. The rules file is the JSON file that contains relative paths to .js files. To properly synchronize a custom zcl.json file, we must copy this rules file, update all paths to be relative to the custom zcl.json and finally run zap-gui or zap-sync with all proper paths. Apart from the synchronization updates several issues with zap generated and added helper functions for obtaining paths. Covered all major scenarios for all west zap commands in unit tests. Added a github workflow to run the tests if any west script is changed. Signed-off-by: Arkadiusz Balys <[email protected]>
ArekBalysNordic
force-pushed
the
west_zap_unit_tests
branch
from
a7af490 to
b95a7b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
west zap-gui, chcek if the zcl.json exists if provided as an argument--fullgenerate argumentSummary
Covered all west zap functions in unit tests.
Added a workflow to run these tests on each zap_*.py function change.
Testing
New unit tests
manifest-pr-skip