[nrf toup][nrfconnect] Allow inheriting DiagnosticDataProviderImplNrf #670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default constructor of DiagnosticDataProviderImplNrf must be protected instead of private to allow inheriting it in the user's implementation. Signed-off-by: Arkadiusz Balys <[email protected]>
NordicBuilder
added a commit
to NordicBuilder/sdk-nrf
that referenced
this pull request
Nov 20, 2025
Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-connectedhomeip#670 Signed-off-by: Nordic Builder <[email protected]>
kkasperczyk-no
approved these changes
Nov 21, 2025
NordicBuilder
added a commit
to NordicBuilder/sdk-nrf
that referenced
this pull request
Nov 21, 2025
Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-connectedhomeip#670 Signed-off-by: Nordic Builder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The default constructor of DiagnosticDataProviderImplNrf must be protected instead of private to allow inheriting it in the user's implementation.
Testing
In NCS