Skip to content

docs(core): disable tutorialkit for firefox #31193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

isaacplmann
Copy link
Collaborator

@isaacplmann isaacplmann commented May 13, 2025

  • Unrevert removing tutorialkit
  • Disable interactive (right) side of tutorialkit when using Firefox
  • Run npm install in the terminal instead of in the preview pane. This makes it so that users can't enter commands until the install command finishes

Revert "Revert "docs(core): publish tutorial kit tutorials (#30973)" (#31179)"

This reverts commit 07474a4.
@isaacplmann isaacplmann requested review from a team, FrozenPandaz and vsavkin as code owners May 13, 2025 15:45
@isaacplmann isaacplmann requested a review from Coly010 May 13, 2025 15:45
Copy link

vercel bot commented May 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ❌ Failed (Inspect) May 16, 2025 1:58pm

Copy link

nx-cloud bot commented May 13, 2025

View your CI Pipeline Execution ↗ for commit 7f5cbd2.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 37m 18s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 16s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 10s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 3s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 5s View ↗
nx documentation ✅ Succeeded 1m 29s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-16 14:32:45 UTC

Update tutorials to use Nx 21.0.3
- Force a reload of the page when navigating between tutorial steps
- Add GA tags to tutorial pages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants